slachiewicz commented on PR #1709: URL: https://github.com/apache/maven-dependency-plugin/pull/1709#issuecomment-6024049569
Converted to draft: the `it.remove()` this deletes is what keeps ignored dependencies out of the warning sections, which are logged right after the filter calls (https://github.com/apache/maven-dependency-plugin/blob/master/src/main/java/org/apache/maven/plugins/dependency/analyze/AbstractAnalyzeMojo.java#L363-L412). Without it every ignored dependency is reported twice and trips `failOnWarning`. The duplicated verbose output from https://github.com/apache/maven-dependency-plugin/issues/1645 comes from the empty-excludes return and is fixed in https://github.com/apache/maven-dependency-plugin/pull/1652. Spotless also fails on the now-unused `java.util.Iterator` import. Verified: `mvn -Prun-its verify -Dinvoker.test=analyze` on master plus this patch → `analyze` IT fails on `assert !buildLog.contains('[WARNING] org.slf4j:slf4j-simple:jar:2.0.16:compile')`; green on master. I'd close this in favour of #1652. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
