slachiewicz commented on PR #1667:
URL: 
https://github.com/apache/maven-dependency-plugin/pull/1667#issuecomment-6025994909

   This no longer compiles on master: 1dfc4b65 (MDEP-969, 
https://github.com/apache/maven-dependency-plugin/commit/1dfc4b659c30170c7ca36d9252ad2d5a64f4ec2d)
 removed maven-dependency-tree, so the 
`org.apache.maven.shared.dependency.graph` imports in 
`DependencyVersionResolver` and `AbstractFromConfigurationMojo` have nothing to 
resolve against. The merge is conflict-free, which is why GitHub still shows it 
as mergeable. Could you rebase and collect the graph through Resolver directly 
(`RepositorySystem.collectDependencies` with a `CollectRequest`; 
https://github.com/apache/maven-dependency-plugin/blob/master/src/main/java/org/apache/maven/plugins/dependency/tree/DependencyTreeBuilder.java
 shows the pattern)? Master now has 
`ResolverUtil.localRepositorySession(File)`, so the new 
`repositorySystemSession(File)` helper can go, and the new `@since` tags should 
be 3.12.0.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to