efegokdemir commented on code in PR #183:
URL: https://github.com/apache/maven-shared-jar/pull/183#discussion_r4219021407
##########
src/main/java/org/apache/maven/shared/jar/JarAnalyzer.java:
##########
@@ -89,7 +84,8 @@ public class JarAnalyzer {
private final JarData jarData;
/**
- * Constructor. Opens the JAR file, so should be matched by a call to
{@link #closeQuietly()}.
+ * Constructor. Opens the JAR file, so should be matched by a call to
{@link #close()} or
Review Comment:
The class Javadoc usage example now wraps `JarAnalyzer` in
try-with-resources, and the regression test verifies the analyzer is closed at
scope exit. No further code change is needed for this request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
