gnodet-bot commented on code in PR #13389:
URL: https://github.com/apache/maven/pull/13389#discussion_r4232520692
##########
maven-core/src/main/java/org/apache/maven/artifact/repository/LegacyLocalRepositoryManager.java:
##########
@@ -57,29 +56,26 @@ public class LegacyLocalRepositoryManager implements
LocalRepositoryManager {
private final LocalRepository repo;
- private final boolean realLocalRepo;
-
public static RepositorySystemSession overlay(
ArtifactRepository repository, RepositorySystemSession session,
RepositorySystem system) {
Review Comment:
💡 **Note:** The `system` parameter is no longer used after the
`DefaultRepositoryLayout` branch was removed. The only caller of `system` was
`DefaultRepositorySystemSessionFactory.setUpLocalRepositoryManager(repository.getBasedir(),
system, session)`, which is now gone. Consider removing this parameter
(breaking API change) or suppressing the warning if the method signature must
stay stable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
