efegokdemir opened a new pull request, #3516: URL: https://github.com/apache/maven-surefire/pull/3516
Fixes #3382 Surefire currently checks `jdkToolchain` requirements only against toolchains configured in `toolchains.xml`. When the Maven Toolchains Plugin has selected a discovered JDK into Maven's build context, Surefire reports no match even if that JDK meets the requirements. If no configured toolchain matches, use the selected build-context toolchain only when it matches the same requirements. Configured matches still take precedence, and a non-matching selection still fails. The toolchains example now documents this behaviour. The regression test failed before the change with the existing `MojoFailureException` and passes with the fix. Validation: - `mvn test -pl maven-surefire-common` — 869 tests, 0 failures, 6 skipped - `mvn -pl maven-surefire-plugin -DskipTests site` — passed --- To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](https://www.apache.org/licenses/LICENSE-2.0) check one of the following: - [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](https://www.apache.org/licenses/LICENSE-2.0) - [ ] I hereby declare that I have filed an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
