Tarun4201 commented on PR #13406:
URL: https://github.com/apache/maven/pull/13406#issuecomment-6108107647
Thanks for the detailed follow-up, @gnodet!
All items have been implemented and pushed:
1. **Test: Property key starting with `profile.`**:
- Added `testProfileScopePropertiesAlreadyPrefixed` to assert that a
property like `profile.custom` is preserved unscoped and not re-prefixed as
`profile.myprofile.profile.custom`.
- Added an explanatory code comment on the `!key.startsWith("profile.")`
guard documenting this behavioral contract.
2. **Test: Profile with null or empty ID**:
- Added `testProfileScopePropertiesWithNullOrEmptyProfileId` asserting
that profiles with `null` or `""` IDs skip scoped injection cleanly without NPE
or generating empty-prefix keys (`profile..prop`).
3. **Early guard for empty properties**:
- Added an early return check in `mergeModelBase_Properties` when
`source.getProperties().isEmpty()` to avoid loop overhead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
