slachiewicz opened a new pull request, #1324: URL: https://github.com/apache/maven-site-plugin/pull/1324
Reporting API 4.1.0 declares `generate(Sink, SinkFactory, Locale)` on `MavenReport` and routes reports that implement only `generate(Sink, Locale)` to it by default, so the `instanceof MavenMultiPageReport` check is no longer needed. Without this change, a report that follows the 4.1.0 deprecation of `MavenMultiPageReport` receives a null `SinkFactory` and loses its sub-pages. This builds once Reporting API 4.1.0 and Doxia 2.2.0 are on Central; both are in vote. Related: apache/maven-reporting-api#91, apache/maven-reporting-api#92. Verified: `mvn -Prun-its verify -Dinvoker.test=full-reporting,MSITE-627,MSITE-842,reportConfig,surefire-report,default-reports,report-changes-generation` against the staging repositories → 7 passed; `full-reporting` renders the javadoc and jxr sub-pages. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
