slachiewicz commented on code in PR #339:
URL:
https://github.com/apache/maven-gh-actions-shared/pull/339#discussion_r4247126866
##########
.github/workflows/maven-verify.yml:
##########
@@ -322,6 +325,8 @@ jobs:
java-version: ${{ inputs.ff-jdk }}
distribution: ${{ inputs.ff-jdk-distribution }}
cache: 'maven'
+ # only the default branch saves caches; other branches and pull
requests restore them
Review Comment:
Not needed: setup-java v6 enables `cache-jdk` by default when `cache` is set
([action.yml](https://github.com/actions/setup-java/blob/de7274f081f381c8f8158605e0321c36c376e2e6/action.yml#L100-L101)),
so this step and the matrix "Set up JDK" step already cache their JDK. The
toolchain steps have no `cache`, which is why they set it explicitly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
