gnodet commented on PR #13394: URL: https://github.com/apache/maven/pull/13394#issuecomment-6154403638
_Fully automatic review from Claude Code_ This PR (#13394, fixing #13347) and #13451 (fixing #13390) are complementary fixes to the same `externalActivationContext` sandbox on `maven-3.10.x`: - **This PR** fixes the IDE case: embedders building their own project from a POM file at `VALIDATION_LEVEL_MINIMAL` should not be sandboxed. Adds `getPomFile() == null` check to `isExternalModelBuildingRequest()`. - **#13451** fixes POM self-activation: a dependency POM's `<properties>` should not activate its own property-based profiles. Removes the POM-property merge from `externalActivationContext()`. Both are needed. The production code changes are in different methods and merge cleanly. There will be a **textual conflict in `ResolvedDependencyProfileActivationTest.java`** since both PRs modify and add tests in the same file — trivial to resolve on rebase. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
