gnodet commented on code in PR #13490:
URL: https://github.com/apache/maven/pull/13490#discussion_r4268401815
##########
compat/maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java:
##########
@@ -285,17 +259,13 @@ public int doMain(String[] args, String workingDirectory,
PrintStream stdout, Pr
final Set<String> realms;
if (classWorld != null) {
realms = new HashSet<>();
- for (ClassRealm realm : classWorld.getRealms()) {
+ for (ClassRealm realm :
((org.codehaus.plexus.classworlds.ClassWorld) classWorld).getRealms()) {
Review Comment:
_Claude Code on behalf of Guillaume Nodet_
Fixed — `installEmbeddedTerminal()` and the dumb-terminal color detection
are preserved. The PR now only changes classworlds imports and adds casts where
needed.
##########
impl/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java:
##########
@@ -364,4 +365,27 @@ private static Object getId(ClassLoader classLoader) {
}
return classLoader;
}
+
+ private void
applyExportOrOpen(org.codehaus.plexus.classworlds.realm.ClassRealm realm,
String spec, boolean open) {
Review Comment:
_Claude Code on behalf of Guillaume Nodet_
Removed from this PR. The method is now in #13494 (per-plugin JPMS
ModuleLayer support) where it is called by `createModularPluginRealm()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
