gnodet-bot commented on code in PR #10906:
URL: https://github.com/apache/maven/pull/10906#discussion_r4273468738
##########
compat/maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java:
##########
@@ -441,6 +451,25 @@ void initialize(CliRequest cliRequest) throws
ExitException {
//
Review Comment:
ℹ️ **Compat-layer: new behavior with no Maven 3.x equivalent**
`MavenCli` is `@Deprecated(since = "4.0.0")` and the compat layer's design
contract is to keep existing Maven 3 embedders working without introducing new
behavior. This block adds runtime MSYS path translation that has no counterpart
in the Maven 3.9.x `MavenCli`.
The bug (MNG-8018) was reported against 3.9.6, and the users most affected
by the exec-maven-plugin scenario are on Maven 3.x. This compat-layer fix helps
Maven 4 users entering via the legacy embedder, but Maven 3.x users remain
unprotected.
Please confirm one of:
1. A 3.9.x backport PR/JIRA exists (link it here so this thread can be
closed), or
2. The scope is intentionally Maven 4-only (document it in the commit
message or PR description).
Without that confirmation, this change is adding new behavior to a
deprecated shim in a way that can confuse users who stay on Maven 3.x and
wonder why the same fix doesn't apply to them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
