desruisseaux commented on code in PR #13470:
URL: https://github.com/apache/maven/pull/13470#discussion_r4274934981
##########
impl/maven-core/src/main/java/org/apache/maven/configuration/internal/EnhancedConfigurationConverter.java:
##########
@@ -111,6 +111,19 @@ public Object fromConfiguration(
}
}
+ private static Object instantiate(Class<?> type, PlexusConfiguration
configuration)
Review Comment:
I'm not familiar with this part of the code, so maybe my remark will be
irrelevant. But the `instantiateObject` method is apparently inherited from the
parent class. Maybe this new `instantiate` method should be added next to it.
Then:
* Check if `instantiateObject` is still used and, if not, remove it.
* This pull request said that this change is "symmetric with
`EnhancedCompositeBeanHelper.setFieldValue`". If symmetric, then can the latter
method share the new `instantiate` method introduced by this pull request (if
that method can put moved to the parent class)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
