gnodet commented on PR #13569: URL: https://github.com/apache/maven/pull/13569#issuecomment-6225106920
Addressed both review comments: **Thread 1 — garbled output from `logChange()`**: converted 8 call-site descriptions from past-tense/passive form to noun phrases, so the helper's appended `" applied"` / `" would be applied"` suffix reads naturally. Files updated: - `CompatibilityFixStrategy`: `"Maven 4 compatibility issues fixed"` → `"Maven 4 compatibility fix"` - `DeduplicateDependenciesStrategy`: `"Duplicate declarations removed"` → `"Duplicate declaration removal"` - `DuplicateElementStrategy`: `"Duplicate XML elements removed"` → `"Duplicate XML element removal"` - `EnforcerVersionRangeStrategy`: `"RequireMavenVersion ranges widened to allow Maven 4"` → `"RequireMavenVersion range widening to allow Maven 4"` - `ModuleNameFixStrategy`: `"Fixed Automatic-Module-Name in …"` → `"Automatic-Module-Name fix in …"` - `NashornCompatibilityStrategy`: `"Injected standalone Nashorn dependency …"` → `"Standalone Nashorn dependency injection …"` - `RepositoryHttpsUpgradeStrategy`: `"HTTP repository URLs upgraded to HTTPS"` → `"HTTP repository URL upgrade to HTTPS"` - `ResourceFilteringStrategy`: `"Added nonFilteredFileExtensions …"` → `"nonFilteredFileExtensions addition …"` - `SourceStrategy`: `"Source configuration migrated to <source> elements"` → `"Source configuration migration to <source> elements"` - `ToolchainPluginStrategy`: `"Added maven-toolchains-plugin …"` → `"maven-toolchains-plugin addition …"` (Call sites already using noun phrases — `ModelUpgradeStrategy`, `InferenceStrategy`, `PluginUpgradeStrategy` — were left unchanged.) **Thread 2 — inconsistent pluralization in `StrategyOrchestrator.logStrategyResult()`**: aligned the dry-run branch from `"POM(s)"` to `"POMs"` to match the else branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
