kunalbuilds-git commented on code in PR #1713: URL: https://github.com/apache/maven-site/pull/1713#discussion_r4304071634
########## content/markdown/guides/mini/guide-3rd-party-jars-remote.md: ########## @@ -61,7 +61,5 @@ Note that `groupId`, `artifactId`, `version` and `packaging` arguments are not i ## Deploying Source Jars -<!-- TODO: Check the following, cause i don't this is true anymore. I assume packaging should be jar--> -<!-- and the classifier should be set to source.--> Review Comment: > Did you test it? I only removed the obsolete TODO comments. I did not change the actual guidance. The existing text (packaging should be set to java-source) looks correct based on current Maven practices, but I didn’t do extra testing beyond reviewing the page. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
