gnodet-bot commented on code in PR #13546:
URL: https://github.com/apache/maven/pull/13546#discussion_r4318141263
##########
impl/maven-core/src/test/java/org/apache/maven/internal/impl/DefaultLifecycleRegistryTest.java:
##########
@@ -18,14 +18,31 @@
*/
package org.apache.maven.internal.impl;
+import java.util.List;
+
+import org.apache.maven.api.Constants;
import org.junit.jupiter.api.Test;
import static org.junit.jupiter.api.Assertions.assertNull;
+import static org.junit.jupiter.api.Assertions.assertTrue;
class DefaultLifecycleRegistryTest {
@Test
void returnsNullImplementationVersionWhenClassHasNoPackage() {
assertNull(DefaultLifecycleRegistry.getImplementationVersion(int.class));
}
+
+ /**
+ * Verifies that when {@code maven.site.lifecycle.disabled} is not set,
+ * the site lifecycle is present in the default stream.
+ */
Review Comment:
🔍 **Nit (dead code):** `System.clearProperty(...)` here has no effect on the
`SITE_DISABLED` static field — that field is captured at
`DefaultLifecycleRegistry` class-load time. The only meaningful precondition
check is the `assertNull` below it. The `clearProperty` is harmless but does
not guard the filter behaviour being tested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
