gnodet-bot commented on code in PR #2218:
URL: https://github.com/apache/maven-resolver/pull/2218#discussion_r4329755560
##########
maven-resolver-tools/src/main/java/org/eclipse/aether/tools/ConfigurationCollectorDoclet.java:
##########
@@ -419,6 +423,16 @@ private Optional<String> getDeprecated(Element element) {
}
}
+ private Collection<String> getSee(DocTreePath path, Element element) {
+ Objects.requireNonNull(path, "path must not be null");
+ Objects.requireNonNull(element, "field must not be null");
Review Comment:
💡 **Nit:** The `element` parameter is validated here but never read in the
method body — only `path` is actually used. This appears to be copy-pasted from
`getDeprecated(DocTreePath, Element)` where `element` IS used (to check the
`@Deprecated` annotation). Either remove the parameter, or remove the dead
`requireNonNull` call.
```suggestion
private Collection<String> getSee(DocTreePath path) {
Objects.requireNonNull(path, "path must not be null");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
