gnodet-bot commented on code in PR #13667:
URL: https://github.com/apache/maven/pull/13667#discussion_r4343702300
##########
impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/LookupInvoker.java:
##########
@@ -353,8 +353,9 @@ protected final void createTerminal(C context) {
MessageUtils.registerShutdownHook(); // safety belt
// Create the build log appender; also sets MavenSimpleLogger sink
Review Comment:
💡 **Nit:** `"summary"` is hardcoded here as the fallback default. The same
string appears as a literal in `ProjectBuildLogAppender` and is documented
across multiple places. If the default ever changes, all three must be updated
manually.
Consider extracting a constant:
```suggestion
ProjectBuildLogAppender projectBuildLogAppender = new
ProjectBuildLogAppender(
determineBuildEventListener(context),
context.options().warningMode().orElse(ProjectBuildLogAppender.DEFAULT_WARNING_MODE));
```
and in `ProjectBuildLogAppender`:
```java
public static final String DEFAULT_WARNING_MODE = "summary";
```
This keeps the canonical default in one place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
