gnodet commented on PR #13613:
URL: https://github.com/apache/maven/pull/13613#issuecomment-6335687234
Fixed the CI javadoc failure and addressed all review comments:
**Javadoc fix (CI failure root cause)**
- `Dialect.java`: replaced cross-module `{@link}` references to
`DialectProvider` and `ModelDialectProvider` (in `maven-api-spi`) with
`{@code}`. These types are not on the classpath of `maven-api-core` during
javadoc generation, causing hard `error: reference not found` failures that
broke the full-build across all platforms.
**Review comments addressed**
1. `ModelDialectManager`: added `@Experimental` annotation — now consistent
with all other new types in this PR
2. `ModelDialectManager#readModel` `@return`: corrected — empty Optional
means the dialect's parser found no file via `locate()`, not a parse failure.
Also documented unchecked exceptions in prose (cross-module `@throws` would
cause the same reference errors).
3. `ModelDialectProvider`: now extends `SpiService` — consistent with
`ModelParser` and `ModelWriter`
Also rebased onto current master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
