gnodet-bot commented on code in PR #13658:
URL: https://github.com/apache/maven/pull/13658#discussion_r4347004017


##########
impl/maven-plugin-mixin/src/site/markdown/usage.md:
##########
@@ -0,0 +1,122 @@
+title: Usage
+author: Maven Team
+date: ${project.version}
+
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+# Usage
+
+## Minimal Maven 4 plugin
+
+A complete, functional Maven 4 plugin with one mojo and one `@Parameter`:
+
+```java
+package com.example;
+
+import org.apache.maven.api.plugin.Mojo;
+import org.apache.maven.api.plugin.annotations.Mojo;

Review Comment:
   🐛 **Conflicting `Mojo` imports in example code.**
   
   The code snippet imports both:
   - `org.apache.maven.api.plugin.Mojo` — the mojo interface
   - `org.apache.maven.api.plugin.annotations.Mojo` — the `@Mojo` annotation
   
   Java disallows two imports with the same simple name in the same compilation 
unit. This example will not compile; the compiler rejects it with a "reference 
to Mojo is ambiguous" or duplicate import error.
   
   Fix — use a qualified annotation name (matching the TouchMojo IT pattern) or 
rename one import:
   
   ```suggestion
   import org.apache.maven.api.plugin.annotations.Mojo;
   import org.apache.maven.api.plugin.annotations.Parameter;
   ```
   
   Then qualify the `implements` clause: `implements 
org.apache.maven.api.plugin.Mojo`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to