elharo commented on code in PR #564:
URL: https://github.com/apache/maven-ear-plugin/pull/564#discussion_r4360001553
##########
src/test/java/org/apache/maven/plugins/ear/EarModuleTest.java:
##########
@@ -18,9 +18,15 @@
*/
package org.apache.maven.plugins.ear;
+import java.io.StringWriter;
+
+import org.codehaus.plexus.util.xml.PrettyPrintXMLWriter;
Review Comment:
These classes are wonky. Please don't add new usages. There are better ways
to write XML to a stream.
##########
src/main/java/org/apache/maven/plugins/ear/AbstractEarModule.java:
##########
@@ -334,13 +334,15 @@ protected void startModuleElement(XMLWriter writer,
Boolean generateId) {
// FIXME: Should we use the mapping using outputFileNameMapping
instead
Review Comment:
seems like addressing this FIXME should be part of this bug
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
