elharo commented on code in PR #560:
URL: https://github.com/apache/maven-ear-plugin/pull/560#discussion_r4360109933
##########
src/main/java/org/apache/maven/plugins/ear/EarMojo.java:
##########
@@ -886,7 +886,9 @@ private void deleteOutdatedResources(final
Collection<String> outdatedResources)
if (resourceFile.lastModified() < startTime) {
getLog().debug("deleting outdated resource " +
outdatedResource);
getLog().debug(outdatedResource + " last modified: " +
resourceFile.lastModified());
- resourceFile.delete();
+ if (!resourceFile.delete()) {
Review Comment:
How bad a problem is this? What's the impact of not deleting? I'm wondering
if this justifies throwing an exception instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
