choksi2212 commented on PR #3547: URL: https://github.com/apache/maven-surefire/pull/3547#issuecomment-6373675821
Hi! This is my first PR from this fork, so I expect the workflow runs are waiting on the first-time maintainer approval to start - happy to wait, just flagging it here in case it slipped through. For a quick orientation: `runOrder=random` currently shuffles the JUnit Platform classes twice with the same seed (the run order calculator's shuffle, then Jupiter's `ClassOrderer$Random` with the forwarded seed), and composing a permutation with itself can never produce some orders - two classes always ran alphabetically, whatever the seed. The PR hands Jupiter the sorted classes in the one-discovery-request case and leaves the single shuffle to it, which also makes the executed order match plain `ClassOrderer$Random` with the same seed. #3544 has the analysis and a reproducer table; the tests reproduce the double shuffle on pristine master in both directions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
