slachiewicz opened a new pull request, #13696: URL: https://github.com/apache/maven/pull/13696
The deprecated `org.apache.maven.api.plugin.testing.stubs` classes are empty subclasses of their relocated counterparts, and Java does not inherit constructors. Plugin tests that still use them fail to compile against 4.0.0-rc-7: - `new ArtifactStub(groupId, artifactId, classifier, version, extension)` and the `SessionStub(Settings)`, `SessionStub(Map)` and three-argument constructors do not exist. - `ProjectStub` setters return the relocated type, so `ProjectStub p = new ProjectStub().setGroupId(...)` no longer compiles. This restores the constructors and overrides the `ProjectStub` setters with a covariant return type, the same approach #12683 took for `ProducedArtifactStub`. Master has already removed the deprecated package, so there is nothing to forward-port. Verified: the three new tests fail to compile against the current shims and pass with this change; `mvn -pl impl/maven-testing verify spotless:check apache-rat:check` → 18 tests, BUILD SUCCESS. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
