slachiewicz opened a new pull request, #552:
URL: https://github.com/apache/maven-build-cache-extension/pull/552
Replaces the retired `org.apache.maven.shared:maven-verifier` 1.8.0 with an
in-repo `org.apache.maven.it.Verifier` shim on
`org.apache.maven.executor:maven-executor` 1.0.0. The shim keeps the package,
class name and the subset of the 1.8.0 API the 130 integration tests call, so
no test changes. maven-verifier 2.0.0 is the final release and drops the
`org.apache.maven.it` package, so a version bump (#550) does not compile.
Every run forks `bin/mvn`. The shim keeps the 1.8.0 behaviour the ITs depend
on:
- Each CLI option string is split into arguments (`-pl module-app -am`),
`${basedir}` is substituted and `//` is collapsed, and `-e --batch-mode` is
always added.
- The project root is the nearest `.mvn` above the working directory,
ignoring `-f`, passed as `MAVEN_BASEDIR`. 1.8.0 ran these ITs embedded and
chose the root this way; the `mvn` script would otherwise root `-f top` at
`top/.mvn` (`Issue87Test`).
The Maven 4 `mvn` script ignores `MAVEN_BASEDIR`. `Issue87Test` fails on the
maven4.0 profile with and without this change.
Verified: `mvn -P run-its,maven3.10 verify` (JDK 21) → 348 ITs, 0 failures,
1 skipped. On `-P run-its,maven4.0` the root-sensitive ITs fail only
`Issue87Test`, which master also fails, along with
`MultiModulePartialBuildTest` and `MultiModulePartialWithAmTest`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
