gnodet-bot commented on code in PR #13701: URL: https://github.com/apache/maven/pull/13701#discussion_r4369861578
########## api/maven-api-spi/src/main/java/org/apache/maven/api/spi/RepositoryListener.java: ########## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.maven.api.spi; + +import org.apache.maven.api.annotations.Consumer; +import org.apache.maven.api.annotations.Experimental; +import org.apache.maven.api.di.Named; + +/** + * Service Provider Interface for observing repository events (artifact and metadata + * resolution, installation, and deployment) contributed by extensions or IDE embedders. Review Comment: 💡 **Nit:** The Javadoc mentions `resolution, installation, and deployment` but the base `org.apache.maven.api.RepositoryListener` interface also covers downloading events (`ARTIFACT_DOWNLOADING`, `ARTIFACT_DOWNLOADED`, `METADATA_DOWNLOADING`, `METADATA_DOWNLOADED`) and descriptor/metadata validity events (`ARTIFACT_DESCRIPTOR_INVALID`, `ARTIFACT_DESCRIPTOR_MISSING`, `METADATA_INVALID`). Consider expanding the description to capture the full scope, e.g.: ```suggestion * resolution, download, installation, deployment, and descriptor/metadata validation events ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
