slachiewicz opened a new pull request, #671:
URL: https://github.com/apache/maven-war-plugin/pull/671
The Maven 4 port evaluates `outputFileNameMapping` with
`StringSearchInterpolator("@{", "}")`, so the documented `@{token}@` syntax
keeps an `@` after every token: `@{artifactId}@-@{version}@.@{extension}@`
becomes `[email protected]@.jar@`. The port had changed the two mapping tests to the
undocumented `@{artifactId}.@{extension}` form, which hid it.
This uses the same `FileNameMapping` as the Maven 3 line
(apache/maven-war-plugin#670), adapted to the Maven 4 `Artifact`, restores the
documented syntax in those tests, and ports the mapping unit tests. As on the
Maven 3 line, the two default mappings become one and each final name is
computed once.
Verified: the two `WarExplodedMojoTest` mapping tests fail on the current
`4.0.x` code and pass with this change; `mvn verify -Prun-its` on Maven
4.0.0-rc-7 → 76 tests, 35 ITs, BUILD SUCCESS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
