jayalakshmi-sasidharan commented on code in PR #533:
URL:
https://github.com/apache/maven-build-cache-extension/pull/533#discussion_r4385162150
##########
src/main/java/org/apache/maven/buildcache/CacheUtils.java:
##########
@@ -286,7 +286,7 @@ public static void unzip(Path zip, Path out, boolean
preservePermissions, boolea
ZipArchiveEntry entry = entries.nextElement();
Path file = out.resolve(entry.getName());
if (!file.normalize().startsWith(out.normalize())) {
- throw new RuntimeException("Bad zip entry");
+ throw new IOException("Bad zip entry");
Review Comment:
@elharo Good point, thanks. Updated this to throw ZipException and adjusted
the regression test to assert the more specific ZipException.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
