gnodet-bot commented on code in PR #480:
URL:
https://github.com/apache/maven-install-plugin/pull/480#discussion_r4386043469
##########
.github/dependabot.yml:
##########
@@ -33,6 +33,20 @@ updates:
# Maven 3 so use SLF4J 1.7.x
- dependency-name: "org.slf4j:*"
versions: [">= 2.0.0"]
+ # Maven 3 line stays on Resolver 1.x (2.x is Maven 4)
+ - dependency-name: "org.apache.maven.resolver:*"
+ versions: [">= 2.0.0"]
Review Comment:
⚠️ **Still unresolved — @slawekjaranowski's concern is correct.** Maven
3.10.0 ships with Resolver 2.0.24 (confirmed in `apache/maven` at tag
`maven-3.10.0`). The CI matrix already tests against Maven 3.10.0 via
`maven-gh-actions-shared@v5`. This ignore rule would block Dependabot from
proposing Resolver 2.x updates on the Maven 3 default branch.
The comment `# Maven 3 line stays on Resolver 1.x (2.x is Maven 4)` is
factually wrong — Resolver 2.x ships with Maven 3.10.x, not exclusively with
Maven 4.
This entire block should be removed:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
