arturobernalg opened a new pull request, #1413: URL: https://github.com/apache/maven-javadoc-plugin/pull/1413
Fixes #372. `addStandardDocletOptions` writes the `-d` (output directory) argument through the `addArgIfNotEmpty` overload that tokenizes its value on commas by default, the same helper used for genuinely comma-separated options like `-link`. When the output directory path contains a comma, it gets split into two separate lines in the javadoc argument file, so javadoc receives a truncated, invalid package name and fails with "Illegal package name". The output directory is always a single path, never a list, so this passes `splitValue=false` for `-d`, the same way `-bottom`, `-doctitle`, `-footer`, `-header`, `-top` and `-windowtitle` already do. Added a test (`testCommaPath`) modeled on the existing `testQuotedPath` apostrophe test, using a fixture project whose basedir contains a comma. It fails with the same "Illegal package name" error on unfixed code and passes after the fix. --- To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](https://www.apache.org/licenses/LICENSE-2.0) check one of the following: - [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](https://www.apache.org/licenses/LICENSE-2.0) - [x] I hereby declare that I have filed an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
