harshab054 commented on issue #2190: URL: https://github.com/apache/maven-resolver/issues/2190#issuecomment-6472728441
Hi @cstamas, I investigated the current Resolver transport architecture for this issue. The existing HTTP transport implementations obtain configured headers through "HttpTransporterUtils.getHttpHeaders(session, repository)". Since the session is already available at this point, a shared implementation could potentially expose the session ID without modifying each individual transport implementation or the transport-task SPI. Before starting an implementation, I'd appreciate clarification on a few design points: 1. Default behavior: Should Resolver automatically attach a session-designator header to HTTP requests, or should it provide an opt-in mechanism for consumers to configure one? 2. Header configuration: Would you prefer a dedicated session-designator configuration property or a dynamic supplier mechanism integrated with the existing HTTP header configuration? 3. Header naming: Should the header name be configurable, and is there an existing naming convention you would prefer? 4. Scope: Is the primary goal to support HTTP transports, or should the design also provide a session designator to non-HTTP transports? My initial investigation suggests that a shared HTTP-header utility could avoid changes to the individual transport implementations. I have not modified any files yet and will wait for guidance on the intended behavior before proposing a patch. Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
