slachiewicz opened a new pull request, #13737:
URL: https://github.com/apache/maven/pull/13737

   `CoreExtensionEntry.discoverFrom` and `PluginDescriptor.getLifecycleMapping` 
read resources from extension and plugin jars with `URL.openStream()`, which 
leaves each jar open in the JVM-wide `jar:` cache 
([JDK-8239054](https://bugs.openjdk.org/browse/JDK-8239054)). Under mvnd, a 
plugin with a forked `lifecycle.xml` that is rebuilt in the reactor is read 
stale or, on Windows, cannot be overwritten. The connections are now uncached, 
so closing the stream closes the jar.
   
   Verified: `PluginDescriptorTest.lifecycleMappingReadsRewrittenJar` fails on 
maven-3.10.x with `EOFException: Unexpected end of ZLIB input stream` and 
passes here.
   
   This is the 3.x side of #13736. Please also backport to maven-3.9.x.
   
   ---
   
   To make clear that you license your contribution under
   the [Apache License Version 2.0, January 
2004](https://www.apache.org/licenses/LICENSE-2.0)
   check one of the following:
   
   - [x] I hereby declare this contribution to be licensed under the [Apache 
License Version 2.0, January 2004](https://www.apache.org/licenses/LICENSE-2.0)
   - [x] I hereby declare that I have filed an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to