slachiewicz opened a new pull request, #1415: URL: https://github.com/apache/maven-javadoc-plugin/pull/1415
`testToFindJavadoc` sets `java.home` to a missing directory so that the javadoc executable is found through the `JAVA_HOME` environment variable. When `JAVA_HOME` is not set, the test failed before restoring `java.home`, and 16 later tests in `JavadocReportTest`, `JavadocJarMojoTest` and `AggregatorJavadocReportTest` then failed with "The environment variable JAVA_HOME is not correctly set". The test now restores `java.home` in a `finally` block and is skipped without `JAVA_HOME`. Verified: `env -u JAVA_HOME mvn test -Dtest='JavadocReportTest,JavadocJarMojoTest,AggregatorJavadocReportTest'` → 17 failures on master, 0 here (1 more skipped). --- To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](https://www.apache.org/licenses/LICENSE-2.0) check one of the following: - [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](https://www.apache.org/licenses/LICENSE-2.0) - [x] I hereby declare that I have filed an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
