sharanggupta opened a new pull request, #2243: URL: https://github.com/apache/maven-resolver/pull/2243
`DirectoryUtilsTest#existsButNotADirectory` called `resolveDirectory()` on a regular file inside a try block and asserted only in the catch block, so it passed even if no `IOException` was thrown. It now uses `assertThrows`; with the not-a-directory check removed from `DirectoryUtils`, the old test stays green and the new one fails. --- To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](https://www.apache.org/licenses/LICENSE-2.0) check one of the following: - [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](https://www.apache.org/licenses/LICENSE-2.0) - [ ] I hereby declare that I have filed an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
