arturobernalg opened a new pull request, #453: URL: https://github.com/apache/maven-help-plugin/pull/453
Fixes #326. AbstractHelpMojo.resolveArtifact() always resolved against project.getRemoteProjectRepositories(). DescribeMojo calls it to resolve a plugin's own jar/pom in two places: the fallback name lookup when a plugin descriptor has no name, and isReportGoal()'s check for whether a goal implements MavenReport. Both are resolving the plugin itself, so a plugin published only to a <pluginRepository> and not also declared as a project <repository> failed to resolve there even though Maven resolved and ran the plugin fine during a normal build. Added a resolveArtifact(artifact, repositories) overload taking an explicit repository list, with the existing resolveArtifact(artifact) delegating to it with project repositories unchanged for its other callers (getMavenProject, EvaluateMojo). DescribeMojo's three plugin-resolution call sites now pass project.getRemotePluginRepositories(). Full module suite, checkstyle and spotless pass locally. To make clear that you license your contribution under the Apache License Version 2.0, January 2004, check one of the following: - [x] I hereby declare this contribution to be licensed under the Apache License Version 2.0, January 2004 - [ ] I hereby declare that I have filed an Apache Individual Contributor License Agreement. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
