arturobernalg opened a new pull request, #1776: URL: https://github.com/apache/maven-dependency-plugin/pull/1776
`includeGroupIds`/`excludeGroupIds` on `copy-dependencies`, `unpack-dependencies`, `build-classpath`, `go-offline` and the other goals built on `AbstractDependencyFilterMojo` used a plain `startsWith` comparison on the group id. Because of that, a group id such as `org.example` also matched an unrelated group id that merely shares the same string prefix, e.g. `org.example2`. This replaces the shared `GroupIdFilter` with one local to the plugin that only matches a listed group id and group ids nested under it, so `org.example` matches `org.example` and `org.example.foo`, but not `org.example2`. It also adds a new `groupIdsExactMatch` parameter so `includeGroupIds`/`excludeGroupIds` can match a group id exactly, the same way `includeArtifactIds`/`excludeArtifactIds` already do. `GoOfflineMojo` builds its own filter list instead of reusing the base class method, so it had the same bug and is fixed the same way. Added unit tests reproducing the bug and covering the new parameter. Full module test suite, checkstyle and spotless pass. Closes #1463. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](https://www.apache.org/licenses/LICENSE-2.0) check one of the following: - [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](https://www.apache.org/licenses/LICENSE-2.0) - [ ] I hereby declare that I have filed an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
