gnodet-bot commented on code in PR #13754:
URL: https://github.com/apache/maven/pull/13754#discussion_r4421240947
##########
impl/maven-testing/pom.xml:
##########
@@ -94,5 +150,14 @@ under the License.
<groupId>org.mockito</groupId>
<artifactId>mockito-core</artifactId>
</dependency>
+ <dependency>
+ <groupId>org.opentest4j</groupId>
+ <artifactId>opentest4j</artifactId>
+ <version>1.3.0</version>
Review Comment:
`opentest4j` is the only dependency in this PR with an explicit version
pinned directly in a leaf module. Every other external dep with no BOM anchor
(e.g. `jimfs`, `xmlunit-core`, `plexus-testing`) has its version managed in the
root `pom.xml`'s `<dependencyManagement>`. `opentest4j` should follow the same
pattern — add it to root pom `<dependencyManagement>` and remove the inline
`<version>` here.
```suggestion
<version>1.3.0</version>
```
Remove this line and add to root `pom.xml` `<dependencyManagement>`:
```xml
<dependency>
<groupId>org.opentest4j</groupId>
<artifactId>opentest4j</artifactId>
<version>1.3.0</version>
</dependency>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
