arturobernalg commented on PR #13727: URL: https://github.com/apache/maven/pull/13727#issuecomment-6525194446
@slawekjaranowski good catches on both. > Which one it is? You're right, that was wrong — there's no such API in maven-core/maven-embedder. The `Prompter` interface plugins use (e.g. maven-archetype, maven-release) comes from plexus-interactivity, a separate optional dependency those plugins declare themselves, not something core exports. Only the colored-message part (`MessageBuilderFactory`) is accurate. Fixed to drop the inaccurate claim. > but we still remove exportedArtifact which allow plugin to call such methods Also right — removing jansi from `exportedArtifact` lets a plugin bring its own jansi dependency and call `AnsiConsole.systemInstall()`/`systemUninstall()` regardless of whether we export the `AnsiConsole` package. Not exporting it doesn't prevent that; it only means Maven isn't the one presenting it as a sanctioned way to touch the console. Reworded the comment to say that accurately instead of implying a protection that doesn't exist. Pushed in 39a2b2759. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
