arturobernalg opened a new pull request, #279: URL: https://github.com/apache/maven-artifact-plugin/pull/279
Fixes #243. CompareMojo.compareWithReference() computed `ko` as `artifacts.size() - ok - ignored.size()`, which counts every artifact that is neither ok nor ignored, including the ones already reported separately as missing. An artifact that's only present in the rebuild and has no reference at all ended up counted both as missing and as ko, inflating the differ count in the log output and in the .buildcompare file. `ko` is now computed directly from `koFilenames`, the list that already tracks artifacts with an actual mismatch, so missing stays a disjoint subset. Added an IT (compare-missing-artifact) that reproduces it: a non-reproducible main jar (1 real ko) plus a classifier jar that only exists in the second build (1 missing). Without the fix it reports ko=2; with the fix ko=1 and missing=1. --- To make clear that you license your contribution under the Apache License Version 2.0, January 2004, check one of the following: - [x] I hereby declare this contribution to be licensed under the Apache License Version 2.0, January 2004 - [x] I hereby declare that I have filed an Apache Individual Contributor License Agreement https://claude.ai/code/session_0153qyh22xBMN1vPfWGz3jSH -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
