Copilot commented on code in PR #182: URL: https://github.com/apache/maven-toolchains-plugin/pull/182#discussion_r4436080648
########## src/it/select-jdk-toolchain-version-range/toolchains.xml: ########## @@ -0,0 +1,32 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- +Licensed to the Apache Software Foundation (ASF) under one +or more contributor license agreements. See the NOTICE file +distributed with this work for additional information +regarding copyright ownership. The ASF licenses this file +to you under the Apache License, Version 2.0 (the +"License"); you may not use this file except in compliance +with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, +software distributed under the License is distributed on an +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +KIND, either express or implied. See the License for the +specific language governing permissions and limitations +under the License. +--> +<toolchains xmlns="http://maven.apache.org/TOOLCHAINS/1.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/TOOLCHAINS/1.0.0 http://maven.apache.org/xsd/toolchains-1.0.0.xsd";> + <toolchain> + <type>jdk</type> + <provides> + <version>11</version> + <vendor>test-vendor</vendor> + </provides> + <configuration> + <jdkHome>${env.JAVA_HOME}</jdkHome> Review Comment: Maven 3 does not interpolate `${env.JAVA_HOME}` in `toolchains.xml`, and Invoker does not filter this file by default. The JDK factory therefore checks this expression as a literal filesystem path and rejects the toolchain before version matching runs, causing the new integration test to fail independently of `matches()`. Use a literal existing directory, as `src/it/toolchains.xml` does, or generate the file with a resolved JDK path in a setup hook. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
