slachiewicz opened a new pull request, #895: URL: https://github.com/apache/maven-shade-plugin/pull/895
Fixes #699. Adds an FAQ entry for the hundreds of overlap warnings when shade runs on a build without `clean`: the JAR plugin keeps the already shaded JAR, and shade shades it again. It recommends `clean` or the JAR plugin's `forceCreation`, as the issue asks, and says why renaming with `finalName` is not a fix. Changing shade's default behaviour, the issue's second point, is out of scope. Verified with shade 3.6.2 and maven-jar-plugin 3.5.1 on Maven 3.10.0, project with one dependency: `mvn verify` then `mvn install` → 445 overlapping classes and resources; with `forceCreation` → only the expected `META-INF/MANIFEST.MF` overlap, on every run; with shade's `finalName` set → the installed `shaded-1.0.jar` has 0 classes of the dependency, `target/shaded-uber.jar` 457. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
