gnodet-bot commented on code in PR #1123:
URL:
https://github.com/apache/maven-compiler-plugin/pull/1123#discussion_r4443872864
##########
src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java:
##########
@@ -586,9 +586,19 @@ final Charset charset() {
protected String outputTimestamp;
/**
- * The algorithm to use for selecting which files to compile.
- * Values can be {@code dependencies}, {@code sources}, {@code classes},
{@code rebuild-on-change},
- * {@code rebuild-on-add}, {@code modules} or {@code none}.
+ * The strategy for selecting which files to compile.
+ * The value can be {@code dependencies}, {@code sources}, {@code
classes}, {@code rebuild-on-change},
+ * {@code rebuild-on-add}, {@code modules} or {@code none}.<p>
+ *
+ * <strong>Despite the word "incremental" in the name, this is not yet as
reliable as the incremental
+ * compilation provided by some IDEs.</strong> It provides an
approximation based on the timestamps of
Review Comment:
⚠️ **Stale clause after field rename.** This sentence referenced the old
field name `incrementalCompilation` — the word "incremental" *was* in its name.
Now that the field is `rebuildStrategy`, the "in the name" clause no longer
makes sense. Drop it or rephrase.
```suggestion
* <strong>This is not yet as reliable as the incremental
* compilation provided by some IDEs.</strong>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
