slachiewicz opened a new pull request, #372: URL: https://github.com/apache/maven-fluido-skin/pull/372
Every banner is wrapped in an `<h1>`. Since #367, an unlinked image banner without a name gets `alt=""`, which is right for a decorative image but leaves an empty heading that screen readers announce (axe `empty-heading`); maven.apache.org's right banner, the Maven logo, is one. Such a banner now goes in a `<div class="banner-decoration">` styled with the `h1`'s margin, font size and line height, so the layout does not move. A banner with a name, a link or `alt` text keeps its `<h1>`. Verified: maven-site rendered with this skin at 1280 px → both banner images and the breadcrumb at the same coordinates as with 2.1.0 (`#bannerRight img` 920,20 340×83); axe `empty-heading` 2 → 0, three `<h1>` → two. `mvn clean install -Prun-its` → 40 of 40 ITs pass, with the sidebar and topbar ITs expecting the new markup. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
