slachiewicz opened a new pull request, #727:
URL: https://github.com/apache/maven-doxia-sitetools/pull/727

   `DefaultSiteRenderer` skipped a page when its output was newer than both its 
source and the site descriptor. Two cases slipped through:
   
   - A new or rebuilt skin: every page kept the old skin until `target/site` 
was deleted.
   - A render that failed half way: the truncated page was newer than its 
source, so the next build kept it as unchanged and published an empty or 
partial page.
   
   The renderer now also compares the skin JAR's timestamp, and deletes the 
output file when rendering it throws. Switching back to an older skin that is 
already in the local repository is still not detected, since its JAR keeps its 
old timestamp; a clean build covers that.
   
   Verified: `DefaultSiteRendererTest#newerSkinRendersUnchangedPageAgain` and 
`#failedRenderLeavesNoPartialPage` → both fail on master, pass with the change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to