slachiewicz commented on issue #333: URL: https://github.com/apache/maven-fluido-skin/issues/333#issuecomment-6600311338
https://github.com/apache/maven-fluido-skin/pull/377 drops minification instead of switching tools. With Bootstrap 5 and highlight.js vendored pre-minified, minify-maven-plugin only handled the skin's own files and AnchorJS, and saved little: | File | Gzipped as written | Gzipped minified | |---|---|---| | `apache-maven-fluido-*.css` (highlight theme, `maven-base.css`, `maven-theme.css`) | 3.6 KB | 1.8 KB | | `apache-maven-fluido-*.js` (`fluido.js`) | 2.3 KB | 1.0 KB | | `anchor-4.3.1.js` | 5.6 KB | 2.5 KB | AnchorJS now uses the `anchor.min.js` from its 4.3.1 release, so the remaining cost is about 3 KB per site, cached after the first page. The alternatives considered: - closure-compiler-maven-plugin (3.1.0, September 2026) minifies JavaScript only, so the CSS would still need a second tool, for about 1.3 KB. - resources-optimizer-maven-plugin (2.7.9, March 2026) covers both, with its own CSS compressor; it would need checking against the skin's custom properties and `[data-bs-theme]` selectors before use. - frontend-maven-plugin with cssnano or esbuild gives the best output, but downloads Node and npm packages into the build for about 10 KB of CSS. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
