gnodet-bot commented on code in PR #13831:
URL: https://github.com/apache/maven/pull/13831#discussion_r4470305887
##########
src/site/markdown/configuring.md:
##########
@@ -7,7 +7,7 @@ to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
Review Comment:
🔴 **Regression — ASF license indent:** The URL changed from 4-space to
3-space indent. The ASF license boilerplate must be preserved exactly as-is.
Please revert:
```suggestion
http://www.apache.org/licenses/LICENSE-2.0
```
##########
src/site/markdown/configuring.md:
##########
@@ -105,10 +125,9 @@ configured in the `~/.m2/extensions.xml` file (user level),
## Maven Command Line Arguments
Maven is a command line tool, and, as such, accepts various command
-line arguments. The `MAVEN_ARGS` environment variable is used to
+line arguments. The `MAVEN_ARGS` environment variable is used to
provide additional arguments to Maven. These arguments will be
prepended to the actual list of command line arguments.
For example, options and goals could be defined with the value
-`-B -V checkstyle:checkstyle`.
-
+`-B -V checkstyle:checkstyle`.
Review Comment:
🔴 **Missing trailing newline:** The PR removes the trailing newline at end
of file (the original had one). Please restore it by ensuring there is a
newline after the last line.
##########
src/site/markdown/configuring.md:
##########
@@ -88,6 +90,24 @@ The main user properties source
`${maven.home}/conf/maven-user.properties` defin
load the _user wide_ user properties from `~/.m2/maven-user.properties` and
the _project_ specific user properties
from `${session.rootDirectory}/.mvn/maven-user.properties`.
+User properties can be referenced when defining dependency versions in a
project's POM. For example, a user-wide property can be defined in
`~/.m2/maven-user.properties`:
+
+```properties
+junit.version=4.13.2
Review Comment:
💡 **Optional — JUnit 5:** Since Maven 4 targets a modern ecosystem, consider
updating this example to JUnit 5:
```suggestion
junit-jupiter.version=5.11.0
```
And in the XML block below, use `org.junit.jupiter:junit-jupiter` with
`<scope>test</scope>`. JUnit 4 still correctly illustrates the feature, so this
is entirely optional.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
