gnodet-bot commented on code in PR #13559:
URL: https://github.com/apache/maven/pull/13559#discussion_r4471061132
##########
its/core-it-suite/src/test/resources/mng-1088/plugin/pom.xml:
##########
@@ -26,14 +26,13 @@ under the License.
<packaging>maven-plugin</packaging>
<name>Maven Integration Test :: MNG-1088 :: Plugin</name>
- <description>
- A simple plugin built within the reactor, to be used by the sibling client
module.
- The concurrent builder must build this plugin first (up to the ready
phase),
- then allow the client to use it — without any pre-installed version.
- </description>
+ <description>Test that the concurrent builder automatically builds a reactor
plugin project up to READY
+ when another project uses that plugin, even if the requested phase is
before "compile".</description>
<properties>
<maven.test.skip>true</maven.test.skip>
+ <maven.version>3.8.6</maven.version>
Review Comment:
🔍 **Dead property** — `${maven.version}` is never referenced in this POM.
The `maven-plugin-api` dep uses `${mavenVersion}` (injected by the IT verifier
via `-DmavenVersion` on the CLI), not `${maven.version}`. This property is dead
code and should be removed.
```suggestion
</properties>
```
(Remove the `<maven.version>3.8.6</maven.version>` line.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
