slachiewicz opened a new pull request, #650:
URL: https://github.com/apache/maven-jar-plugin/pull/650

   Three ITs could not fail: MJAR-70-recreation only printed a warning when the 
jar was not recreated, and both MJAR-296 ITs asserted `.cvsignore`, which 
plexus-utils 4.1.0 no longer excludes by default. They become unit tests that 
assert `forceCreation` replaces an existing jar (and that it is kept without 
it), and that default excludes drop `.DS_Store`, `.svn` and backup files unless 
`addDefaultExcludes` is false. MJAR-62-toolchain is removed: github-470 runs 
the same project with the same toolchain assertion.
   
   Verified: unit tests 3 → 7; `mvn -B -P run-its verify` → Passed: 32, Failed: 
0, Skipped: 2; flipping `setForced` and `setUsingDefaultExcludes` each fails 
its test
   
   ---
   
   To make clear that you license your contribution under
   the [Apache License Version 2.0, January 
2004](https://www.apache.org/licenses/LICENSE-2.0)
   check one of the following:
   
   - [ ] I hereby declare this contribution to be licensed under the [Apache 
License Version 2.0, January 2004](https://www.apache.org/licenses/LICENSE-2.0)
   - [x] I hereby declare that I have filed an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to