slachiewicz opened a new pull request, #739: URL: https://github.com/apache/maven-checkstyle-plugin/pull/739
Moves 23 ITs that only check how check and report parameters shape the result (source and resource directories, includes and excludes, inline rules, violation severity and limits, ignores, generated sources, plain output, charset, header and cache files, aggregation) into `CheckstyleViolationCheckScenarioTest` and `CheckstyleReportScenarioTest`, keeping each IT's assertions; three more are removed because existing unit tests already assert the same thing. Each new test fails when the production line or fixture it guards is broken. The `NewlineAtEndOfFile` ignore in the check-fail, 220 and 295 fixtures never matched, since those sources end with a newline; it is dropped. Part of apache/maven#13822. Verified: unit tests 26 → 53 (1 skipped), all pass, also under `-Duser.language=de -Duser.timezone=Asia/Tokyo`; ITs 49 → 22, all pass with `-P run-its` --- To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](https://www.apache.org/licenses/LICENSE-2.0) check one of the following: - [ ] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](https://www.apache.org/licenses/LICENSE-2.0) - [x] I hereby declare that I have filed an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
