elharo commented on code in PR #2138:
URL: https://github.com/apache/maven-resolver/pull/2138#discussion_r4480432336
##########
maven-resolver-api/src/main/java/org/eclipse/aether/collection/CollectResult.java:
##########
@@ -91,23 +86,20 @@ public CollectResult addException(Exception exception) {
/**
* Gets the dependency cycles that were encountered while building the
dependency graph.
*
- * @return The dependency cycles in the (raw) graph, never {@code null}.
+ * @return An unmodifiable list of the dependency cycles, never {@code
null}.
Review Comment:
an
##########
maven-resolver-api/src/main/java/org/eclipse/aether/collection/CollectResult.java:
##########
@@ -66,10 +64,10 @@ public CollectRequest getRequest() {
/**
* Gets the exceptions that occurred while building the dependency graph.
*
- * @return The exceptions that occurred, never {@code null}.
+ * @return An unmodifiable list of the exceptions that occurred, never
{@code null}.
Review Comment:
An --> an
##########
maven-resolver-api/src/main/java/org/eclipse/aether/collection/CollectResult.java:
##########
@@ -91,23 +86,20 @@ public CollectResult addException(Exception exception) {
/**
* Gets the dependency cycles that were encountered while building the
dependency graph.
*
- * @return The dependency cycles in the (raw) graph, never {@code null}.
+ * @return An unmodifiable list of the dependency cycles, never {@code
null}.
*/
public List<DependencyCycle> getCycles() {
- return cycles;
+ return Collections.unmodifiableList(cycles);
}
/**
* Records the specified dependency cycle.
*
- * @param cycle The dependency cycle to record, may be {@code null}.
+ * @param cycle The dependency cycle, may be {@code null}.
Review Comment:
the
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
