gnodet-bot commented on code in PR #13853:
URL: https://github.com/apache/maven/pull/13853#discussion_r4484097272
##########
impl/maven-impl/src/test/java/org/apache/maven/impl/DefaultExtensibleEnumRegistryTest.java:
##########
@@ -99,6 +104,52 @@ void fallsBackToBuiltinWhenDynamicLookupFindsNothing() {
assertSame(foo, registry.lookup("foo").orElseThrow());
}
+ // --- isVisibleFrom tests ---
+
+ @Test
+ void visibleFromNullClassLoaderAlwaysReturnsTrue() {
+ TestProvider provider = () -> List.of(CUSTOM);
+ assertTrue(ExtensibleEnumRegistries.isVisibleFrom(provider, null));
+ }
+
+ @Test
+ void visibleFromSameClassLoaderReturnsTrue() {
+ TestProvider provider = () -> List.of(CUSTOM);
+ ClassLoader cl = provider.getClass().getClassLoader();
+ assertTrue(ExtensibleEnumRegistries.isVisibleFrom(provider, cl));
+ }
+
+ @Test
+ void visibleFromChildOfParentClassLoaderReturnsTrue() {
+ TestProvider provider = () -> List.of(CUSTOM);
+ ClassLoader parent = provider.getClass().getClassLoader();
+ ClassLoader child = new URLClassLoader(new URL[0], parent);
+ assertTrue(ExtensibleEnumRegistries.isVisibleFrom(provider, child));
+ }
+
+ @Test
+ void notVisibleFromUnrelatedClassLoader() {
+ TestProvider provider = () -> List.of(CUSTOM);
+ ClassLoader unrelated = new URLClassLoader(new URL[0], null);
Review Comment:
💡 `URLClassLoader` implements `Closeable` — wrap in try-with-resources even
for zero-URL loaders:
```suggestion
try (ClassLoader unrelated = new URLClassLoader(new URL[0], null)) {
```
(Same pattern applies at lines 126, 148–149 for the other
created-but-never-closed instances.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
